Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: [PATCH 03/16] more tr portability test script fixes

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:44:24

Jeff King [off-list ref] writes:
On Tue, Mar 18, 2008 at 11:23:02PM +0100, Alex Riesen wrote:
quoted
Jeff King, Wed, Mar 12, 2008 22:31:06 +0100:
quoted
-    tr '\000' '\012' <"$1" | sed -e "$sanitize_diff_raw_z" >.tmp-1
-    tr '\000' '\012' <"$2" | sed -e "$sanitize_diff_raw_z" >.tmp-2
+    perl -pe 'y/\000/\012/' <"$1" | sed -e "$sanitize_diff_raw_z" >.tmp-1
+    perl -pe 'y/\000/\012/' <"$2" | sed -e "$sanitize_diff_raw_z" >.tmp-2
These break in presence of ActiveState Perl on Windows.

I suggest replacing such simple construction with a simplified,
in-tree, version of tr.
<sigh> It's sad that it must come to that, but your test-tr patches seem
like the only sane choice. They seem to work fine on my Solaris box.
I am very tempted to say that it might make more sense to declare
ActiveState unsupported.  How many times have we suffered from it, and
notice it was only from Alex every time, nobody else?  Are there silent
majorities involved here?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help