Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH 06/16] add test_cmp function for test scripts

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:44:22

Jeff King [off-list ref] writes:
On Wed, Mar 12, 2008 at 03:12:45PM -0700, Junio C Hamano wrote:
quoted
I think I have an earlier round of this in 'pu'.
Oops, so you do. I remember discussing it but didn't recall a patch
coming out of it.

I see you have queued mine now in pu over yours. I actually think yours
looks a little nicer (you sanity-check the comparator, and you are more
careful with stdin (something that I considered, but figured we could
add if something actually broke)).

Any reason not to keep your existing one over mine?
Yours is much simpler.

And it is tested on the field, so if it ever breaks I have somebody else
to blame ;-)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help