Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: [PATCH v4] gc: call "prune --expire 2.weeks.ago" by default

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:44:22

Johannes Schindelin [off-list ref] writes:
quoted
Yuck; approxidate() returns ulong.  Can subtracting a ulong from another
ever go negative?

Besides, because there is no guarantee of the order of evaluation between
these two approxidate() calls, you may get +1 or -1 on the second boundary.

I think the reason why you did not catch it in your test is because your
tests are half complete; they test only what you wanted to catch
(misconfigured case) and do not test the other half (properly working
case).
Yes, probably.  Of course, comparing a difference to 0 is absolutely 
moronic.

I should have written

				approxidate(value) >= approxidate("now"))

in the first place.
Eh, sorry, but why?
So, could you tell me, please, if I should resend the patch with your 
--prune documentation, or without?
I like Nico's suggestion to put that "historical notes" in RelNotes, so
the documentation part is fine as is.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help