Re: [PATCH] Write diff output to a file in struct diff_options

Daniel Barkalow [off-list ref] writes:

Signed-off-by: Daniel Barkalow <redacted>
---
I remember there being some expectation that this would be difficult, but 
it was a pretty straightforward conversion, so I'm wondering if I've 
missed something. In any case, this is missing tests and documentation for 
--output=, but I really want it to use directly for rebase-interactive, 
and I only did the command line option so I could do informal testing.

Looks Ok at lesat to my cursory review.

Some people however seemed to have had plans to take this even further and
optionally emit into strbuf; I suspect that was the difficulty you were
remembering about?