Re: [PATCH] unquote_c_style: fix off-by-one.

Adeodato Simó [off-list ref] writes:

* Pierre Habouzit [Fri, 07 Mar 2008 01:44:01 +0100]:

quoted

On Thu, Mar 06, 2008 at 10:10:41PM +0000, Junio C Hamano wrote:

quoted

Pierre Habouzit [off-list ref] writes:

quoted

quoted

quoted

Thanks to Adeodato Simò for having caught this.

quoted

quoted

quoted

Signed-off-by: Pierre Habouzit <redacted>

quoted

quoted

Thanks.  I would have appreciated a comment that said something about what
external breakages this one caused, so that we can have an entry in "bugs
fixed" list.

quoted

quoted

A quick audit of the existing callers suggests that it is fast-import.

Yes, it's fast-import. In particular, trying to rename a file whose name
contains spaces:

  R "file 1.txt" file 2.txt
                ^
                unquote_c_style() eats that space, thus fast-import
                fails with:

                fatal: Missing space after source: R "file 1.txt" file 2.txt

Thanks.