Thread (7 messages) flat view 7 messages, 4 authors, 2016-06-15

Re: [PATCH] shortlog: take the first populated line of the description

From: Nicolas Pitre <hidden>
Date: 2016-06-15 22:44:20

On Wed, 5 Mar 2008, Andy Whitcroft wrote:
Way back the perl version of shortlog would take the first populated line
of the commit body.  The builtin version mearly takes the first line.
This leads to empty shortlog entries when there is some viable text in
the commit.

Reinstate this behaviour igoring all lines with nothing but whitespace.

Signed-off-by: Andy Whitcroft <redacted>
---

	This seems to be an improvement, returning to the original
	behaviour.  I cannot think of any good reason not to take the first
	populated line for a shortlog.	The alternative less agressive
	compromise might be to skip only completly empty lines at the
	start, but I am not sure that adds any value.

	I seem to get a lot of these in converted SVN commits.

	Comments?
Maybe it is the SVN conversion that needs fixing?


Nicolas
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help