Re: [PATCH 6/9] Completely move out worktree setup from setup_git_directory_gently()

"Nguyen Thai Ngoc Duy" [off-list ref] writes:

On Thu, Feb 28, 2008 at 9:17 AM, Junio C Hamano [off-list ref] wrote:

quoted

Nguyễn Thái Ngọc Duy [off-list ref] writes:

 > -     prefix = setup_git_directory_gently(&nongit);
 > -     init_revisions(&rev, prefix);
 > +     setup_git_directory_gently(&nongit);
 > +     init_revisions(&rev, NULL);

quoted

@@ -233,19 +233,20 @@ int cmd_diff(int argc, const char **argv, const char *prefix)

 > ...

quoted

-     init_revisions(&rev, prefix);

 > +     init_revisions(&rev, NULL);

 Hmm.  How is the effect of this change compensated later to give
 proper prefix value to rev.diffopt.prefix?

I assume you meant rev.prefix? rev.prefix is set right before
setup_revisions(). (grr.. I think I left an redundant
rev.diffopt.skip_stat_unmatch assignment)

I did mean rev.diffopt.prefix that is initialized by the last
four lines in init_revisions() from the value of prefix you
pass.