Re: [PATCH] Don't use GIT_CONFIG in t5505-remote

Daniel Barkalow [off-list ref] writes:

For some reason, t5505-remote was setting GIT_CONFIG to .git/config
and exporting it. The sole effect of this was to cause the tests to
fail if "git clone" obeyed it (which it presumably should).

Your patch is correct, as it was a no-op to set and export
GIT_CONFIG to .git/config there as Jeff pointed out.

But I think git-clone should explicitly ignore user-supplied
GIT_CONFIG in the environment if exists, when it wants to update
the configuration file for the new repository it created, as I
mentioned in the other message.

And I think scripted version has the same issue.  It would
update random places GIT_CONFIG points at, when it wants to
modify the configuration file for the new repository it just
built, which would be a bug.