Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH] Move worktree setup out of setup_git_directory*

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:44:17

"Nguyen Thai Ngoc Duy" [off-list ref] writes:
Interesting. It currently does chdir(). But it is pointless now as
worktree should not be accessed until setup_work_tree() is called.
setup_git_directory* should not return a prefix at all.
...
I guess I just need to verify your statements and put them to
Doc/technical/api-setup.txt ;)
The above, as I said, was written out of thin air without
re-reading the current code nor carefully reading what your
patch does, so I am afraid there needs a lot more than that
to happen before we have something to validate the callers
against, but I think you got why I think it is a good idea to
have that documented.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help