Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: [BUG] git filter-branch failed to suppress a file with an accentuated letter in the filename

From: Johannes Schindelin <hidden>
Date: 2016-06-15 22:44:14

Hi,

On Fri, 15 Feb 2008, Junio C Hamano wrote:
Remi Vanicat [off-list ref] writes:
quoted
The culprit seem to be those line of filter-branch: (around line 279) 
		git diff-index -r $commit | cut -f 2- | tr '\012' '\000' | \
			xargs -0 git update-index --add --replace --remove
git diff-index giving the filename as "foo/bar\303\251"
I have to wonder in what century filter-branch was written ;-)

Shouldn't those two lines be:

	git diff-index -r --name-only $commit |
        git update-index --add --replace --remove --stdin

these days, without any of the cut and cruft?
Maybe even using "-z" in both cases?

Having said that, I do not understand why the old code did not work.  Will 
have a look later today.

Ciao,
Dscho
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help