Re: What's in git.git

On Tue, Feb 12, 2008 at 10:15:28AM +0100, Daniel Stenberg [off-list ref] wrote:

On Mon, 11 Feb 2008, Junio C Hamano wrote:

quoted

Mike Hommey (1):
Work around curl-gnutls not liking to be reinitialized

But why reinitialize libcurl at all in the first place? This "work-around"
should rather be the standard behavior since there should be no logical 
reason to re-initialize libcurl's global state during a git's execution.

Even though Mike correctly identified a libcurl bug, it also indirectly 
identified a git flaw: re-initialization with the curl_global_* functions 
is pointless and only wastes time.

The important bit in the commit message reads:

We work around this by removing the http_init and http_cleanup calls
from get_refs_via_curl, replacing them with a transport->data
initialization with the http_walker (which does http_init).

Which means there remains only one initialization. I agree it's not a
workaround anymore, but the word remained from the 3 previous attempts,
which were workarounds.

Mike