Re: [PATCH] Add gitattributes file making whitespace checking pickier

On Sat, Feb 09, 2008 at 09:22:00PM +0100, Jakub Narebski wrote:

J. Bruce Fields wrote:

quoted

On Sat, Feb 09, 2008 at 11:36:31AM -0800, Jakub Narebski wrote:

quoted

"J. Bruce Fields" [off-list ref] writes:

quoted

 gitweb/gitweb.perl                                  |  566 ++--
 index-pack.c                                        |   30 

gitweb (at my insistence) uses tabs for indent, but spaces for align,
so that the layout is [roughly] preserved independently of the tab
size. IMHO it is superior style, but much harder to check
algorithmically (although I send some sketch of idea how to check that
at least for aligned commands). That is why there is such a big change.

I'd rather have real bugfixes, real documentation improvements, new
features instead of such bikeshedding.  If someone is making a change
somewhere, he/she can fix the whitespace in the neighbourhood.

I agree completely.  Did I suggest otherwise?

Ah, sorry, I have misunderstood.

This is an informational piece, then, isn't it?

Yeah, I was generating the diff just as a way to get an idea which paths
which policies should apply to.

That still doesn't rise much above bikeshedding, but it's not quite as
bad as actually trying to apply such a diff...

--b.