Re: [PATCH] git help -w should not create nohup.out

On Thu, Feb 07, 2008 at 07:40:21PM -0800, Junio C Hamano wrote:

Johannes Schindelin [off-list ref] writes:

quoted

Hi,

On Fri, 8 Feb 2008, Dmitry Potapov wrote:

quoted

git-help--browse uses 'nohup' to launch some browsers.

Why?

"nohup" should be used to start a program that should persist even after 
you logged out.  I fail to see how this should be sensible for "git help 
-w".  So "off with the head", uh, do away with the "nohup", I say!

True.  Christian, what was the reason you added nohup?
I would imagine if you did this:

	(1) open a new xterm;

        (2) in that xterm, run the browser, perhaps from
            git-help--browse, but without nohup, in the
            background;

	(3) exit the terminal

then the browser might get upset, losing its controlling
terminal.

I also thought so, therefore, I suggested to redict the output to
/dev/null instead of removing "nohup", but now after some testing,
it seems there is no need for "nohup" here. So, unless Christian
has a good reason for "nohup", I agree with Johannes that "nohup"
should be removed.


Dmitry