Re: [PATCH 1/2] Reduce the number of connects when fetching
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:44:10
Daniel Barkalow [off-list ref] writes:
This shares the connection between getting the remote ref list and getting objects in the first batch. (A second connection is still used to follow tags) ---
No signoff.
There's a bug here, fixed in the next patch, but it's just cosmetic (we hang up on the remote end unexpectedly if we turn out not to need anything), and I think reorganizing changes to not do that makes the changes harder to follow.
quoted hunk ↗ jump to hunk
@@ -706,9 +703,34 @@ int cmd_fetch_pack(int argc, const char **argv, const char *prefix) if (!dest) usage(fetch_pack_usage); - ref = fetch_pack(&args, dest, nr_heads, heads, NULL); + int fd[2]; + struct child_process *conn = git_connect(fd, (char *)dest, args.uploadpack, + args.verbose ? CONNECT_VERBOSE : 0);
Decl after statement. But other than that, good job. I did not realize it would be doable this cleanly. Will squash all three and queue for 'next'.