Re: [bug] generic issue with git_config handlers

Le jeudi 31 janvier 2008, Pierre Habouzit a écrit :

quoted

On Thu, Jan 31, 2008 at 09:25:32AM +0000, Junio C Hamano wrote:

quoted

Pierre Habouzit [off-list ref] writes:

quoted

  One of my co-workers stumbled upon a misfeature of the git config
parser. The following syntax is allowed:

    [section]
	 foo

Yeah, that is how "truth" value of boolean is spelled.

quoted

[user]
    name

That's very unfortunate.  Whatever is expecting string value
should check for NULL.  Fix should probably be easy enough for
any git-hacker-wannabe to tackle ;-)

  I think so too, though my count is something like 40 functions to
investigate (the 40 handlers) and where it recurses into ;) Too much
work for the time I have right now.

I would suggest this patch:

---8<---

diff --git a/config.c b/config.c
index 526a3f4..92613c5 100644
--- a/config.c
+++ b/config.c

@@ -139,7 +139,7 @@ static int get_value(config_fn_t fn, char *name, 

unsigned in
                if (!value)
                        return -1;
        }
-       return fn(name, value);
+       return fn(name, value ? value : "");
 }