Re: [PATCH 2/3] fsck_commit: remove duplicate tests

On Mon, Feb 04, 2008 at 12:04:31AM +0000, Johannes Schindelin wrote:

On Sun, 3 Feb 2008, Junio C Hamano wrote:

quoted

Martin Koegler [off-list ref] writes:

quoted

All tests on the commit buffer in fsck_cmd are ready done by 
parse_commit_buffer.

This patch rips out all redundant tests.

As I believe in belt-and-suspenders when it comes to validation, I am 
somewhat uneasy with this change.

Besides, should we really change fsck?  It's not _that_ much of a 
performance-critical operation.  Accuracy is much more important.

fsck is the reason I trust git with my data.

Then please drop this patch. I hope the other two patches are OK.

mfg Martin Kögler