Thread (5 messages) flat view 5 messages, 5 authors, 2016-06-15

Re: [PATCH] gitignore(5): Allow "foo/" in ignore list to match directory "foo"

From: Jeff King <hidden>
Date: 2016-06-15 22:44:09

Possibly related (same subject, not in this thread)

On Thu, Jan 31, 2008 at 02:35:33AM -0800, Junio C Hamano wrote:
Without "foo/", you do not have to pay the price, so I think
that is a sane optimization, but at the same time it would make
it worse if "foo/" is actually used.  excluded_1() is called for
the same pathname from a loop to check for a match and you would
end up running lstat(2) three times (once each for EXC_CMDL,
EXC_DIRS and EXC_FILE).

But maybe people who want "foo/" deserve it.  I dunno.
Ah, I didn't look at it that closely.

To do the laziness right, I think you would need to pass a pointer to
the dtype around, and just fill it in the first time it is needed.

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help