Johannes Schindelin [off-list ref] writes:
quoted
This is not to be applied (especially before auditing the callers), but
to be thought about. Although it passes all the tests...
It certainly is tempting.
quoted
+ while (c == '/')
+ c = *src++;
+ src--;
This is ugly. I would like this better:
while (src[1] == '/')
src++;
Whatever. That was just for discussion.
quoted
+const char *prefix_path(const char *prefix, int len, const char *path)
+{
+ const char *orig = path;
+ char *sanitized = xmalloc(len + strlen(path) + 1);
There _has_ to be a way to avoid malloc()ing things that will _never_ be
free()d again with every second patch ;-)
Huh? prefix_path() already allocates for rewritten pathspec
entries; this is nothing new.