Re: [PATCH] Reduce the number of connects when fetching

On Sat, 26 Jan 2008, Johannes Schindelin wrote:

Hi,

On Fri, 25 Jan 2008, Daniel Barkalow wrote:

quoted

This shares the connection between getting the remote ref list and 
getting objects in the first batch. (A second connection is still used 
to follow tags)

I applied this locally, and now I get a few "fatal: The remote end hung up 
unexpectedly" errors; when I started "git fetch" in a gdb session, it did 
not stop at die_builtin(), which leads me to believe that the error comes 
from upload-pack.

Any ideas?

In fact, it seems to me that quickfetch short-circuits the fetch portion 
of the connection, and, if it takes care of everything (i.e., there's 
nothing to do), the connection gets dropped while the remote is still 
expecting communication. Essentially harmless but wrong, and I'll clean it 
up.

	-Daniel
*This .sig left intentionally blank*