Thread (3 messages) flat view 3 messages, 2 authors, 2016-06-15

Re: I'm a total push-over..

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:44:07

Possibly related (same subject, not in this thread)

Linus Torvalds [off-list ref] writes:
Ok, here's an interesting patch based on the current 'next' (since it very 
intimately requires the new in-memory index format).
This is nice.  It does not do anything specific with HFS+ issues
but aims for faster look-ups, which would help everybody.

Two things I noticed (only two, not necessarily because you are
good but mostly because I am still mired in day job and could
not get enough uninterrupted minutes to read the patch ;-)):

 - You might want to store the hash table (once computed) in the
   index extension section, and lazily unpack the table the
   first time index_name_exists() or set_index_entry() is called
   on the given istate, instead of unpacking it immediately when
   you read from the disk.  That way, ls-files does not have to
   suffer at all.

 - You would need to get rid of the table in discard_index().
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help