Re: [PATCH] git-commit: exit non-zero if we fail to commit the index

Brandon Casey [off-list ref] writes:

---


Junio C Hamano wrote:

quoted

Brandon Casey [off-list ref] writes:

quoted

quoted

 We would need to tell the user that the index is not where
it is when we detect the error, though.

The new index we are trying to rename will be deleted.
Are you saying we should 
  warn the user that the index is now out of sync?

Yeah, something like that.  But I think that once this happens
there is no easy and sane recovery path for the user, as the
most likely cause of the failure there would be the user running
out of quota, so "git reset HEAD" which may be the way to
recover from that failure would not have enough room to create a
new index file anyway.

If you're interested, here's a patch.

Looks Ok from a quick glance.  I am mired at day job this week
so it may take a while for me to come up with a commit log
message though.