Re: [PATCH] http-push: making HTTP push more robust and more user-friendly

Hi,

On Mon, 21 Jan 2008, Mike Hommey wrote:

On Mon, Jan 21, 2008 at 12:18:14PM -0800, Junio C Hamano wrote:

quoted

Johannes Schindelin [off-list ref] writes:

quoted

IMHO it is safer to disable it for curl < 7.0xa -- even if it affects a 
number of distros -- than to give the illusion that it works, when it does 
not.

As for fixing it in the non-MULTI case, I have a hunch that Mike's 
cleanups will help that, but that this is a 1.5.5 feature.

So, I would like to read in the ReleaseNotes something like this:

-- snip --
Support for pushing via HTTP was broken with curl versions prior to 7.16, 
so we disabled it for now.  However, it is likely that a major cleanup of 
the http transport code -- scheduled after the release of git 1.5.4 -- 
will be supported with more curl versions.
-- snap --

That's tempting but I suspect that it might be a wrong approach.

I think two important questions are:

 * Do we know that the current code is broken for everybody, or
   just broken for the majority of people who do nontrivial
   things?

IIRC, http-push simply doesn't work without CURL_MULTI. 

I have to agree.  When I last tried without CURL_MULTI (IIRC it was just 
once, when I had an ancient curl available), it would just not work, and I 
gave up/in and installed a newer curl, thus enabling CURL_MULTI.

quoted

 * Is the code in 1.5.3.8 any better?  IOW, did we make it worse
   during 1.5.4 cycle?

Changes in http-push.c since 1.5.3.8 mostly involve cleanup. It
didn't change anything about CURL_MULTI or lack thereof.

I meant to look into http-push and curl_multi, ever since Daniel asked me 
(or for that matter, other people knowing about the issues) do do it.

Alas, I forgot about it.

So I am half-convinced that http-push w/o CURL_MULTI was broken since long 
ago (pre 1.5.3).

I'll try tomorrow, since I have a (kinda) working http-push setup 
available then.

Ciao,
Dscho