Thread (11 messages) 11 messages, 4 authors, 2016-06-15

Re: [PATCH] git-commit: add a prepare-commit-msg hook

From: Johannes Schindelin <hidden>
Date: 2016-06-15 22:44:07

Hi,

On Mon, 21 Jan 2008, Paolo Bonzini wrote:
I would like to understand why both of you have not considered the point 
that the script would need the updated index from git-commit.
I have.  But I want to avoid a regression at any cost.  And your patch 
just looks to me like it could do that.

But it _has_ been already suggested that you could provide arguments for 
the existing msg-hook, which would not break anything, since the hook does 
not get any argument yet, and therefore existing hooks would be 
unaffected.

Also, the change would be non-intrusive, easy-to-review, and it would not 
take so much time away from the bug-fixing that we want to do right now in 
the rc-cycle.

Okay?
Dscho
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help