Re: [PATCH] http-push: making HTTP push more robust and more user-friendly

Hi,

On Sat, 19 Jan 2008, Grégoire Barbier wrote:

Johannes Schindelin a écrit :

quoted

 It gives a better warning if the URL cannot be accessed, alright. But
 I hate the fact that it introduces yet another function which does a
 bunch of curl_easy_setopt()s only to start an active slot and check
 for errors.

 Currently, I am not familiar enough with http-push.c to suggest a
 proper alternative, but I suspect that the return values of the
 _existing_ calls to curl should know precisely why the requests
 failed, and _this_ should be reported.

Mike Hommey a écrit :

quoted

FWIW, I have a work in progress refactoring the http code, avoiding a 
great amount of curl_easy_setopt()s and simplifying the whole thing. 
It's been sitting on my hard drive during my (quite long) vacation. I 
will probably start working again on this soonish.

4) I agree with Johannes. However I am not familiar enough with curl to 
write the proper alternative. I create the new function by copy/paste of 
an existing one. I'm not 100% sure that it has no resource leaks or 
other bugs, but it's called only once at http-push start, and thus is 
likely not to do heavy damage...

I agree that it is too late in the rc cycle (actually, I cannot wait for 
the end of it...) to do heavy refactoring, and this function is small 
enough that it should not hurt the refactoring effort, especially given 
that you want to work on that end anyway.

So please strike this one of my objections.

Thanks for all your work,
Dscho