Re: [PATCH 3/5] git-submodule: New subcommand 'summary' (3) - limit summary size

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:44:04

Ping Yin [off-list ref] writes:

quoted hunk

@@ -265,6 +267,10 @@ set_name_rev () {
 #
 modules_summary()
 {
+	summary_limit=${summary_limit:-1000000}

Why a million?

+	summary_limit=$((summary_limit<0?1000000:summary_limit))

This is doubly bashism.  Variables must be referenced with $,
and $(( conditional ? iftrue : iffalse )) is not POSIX.