Re: [PATCH] Add committer and author names to top of COMMIT_EDITMSG.

On Fri, Jan 11, 2008 at 05:53:12PM -0800, Junio C Hamano wrote:

The official party line to defend the existing behaviour is that
there is no need to configure anything, when the host and gecos
is done properly.  But I tend to agree with you that quite a lot
of systems are not "done properly", and users cannot do much
about it in some cases.  I think most of misconfigured systems
are personal boxes they have control over but not all.

I think there are plenty of reasons for the host/gecos information not
being useful. Is a workstation whose hostname is not a valid mailing
address really not "done properly"?

Perhaps we could disable the code that reads from hostname and
gecos, and instead always force the users to configure.  But
that kind of change is not something I'd want to be discussing
right now.

This is obviously not 1.5.4 material, so I haven't given it that much
thought either. But perhaps Stephen's "author message" should simply
trigger any time the author is pulled from gecos? I suppose that would
annoy people who use this feature all the time, but they can silence the
"warning" with a simple git-config.

-Peff