Re: [PATCH decompress BUG] Fix decompress_next_from() wrong argument value

"Marco Costalba" [off-list ref] writes:

Patch to be applied above decompress helper series.

No way.  That will mean that the resulting series will start
with a known bug.

Not to be pedantic, but have a function that gives two really
coupled values, as a buffer pointer and the size, the first as return
value and the second through a variable at file scope is not something
you are going to see advertised in the programming books!

Sorry for this little rant but this bug really made me crazy.

Pardon me.  Are you talking about a bug you introduced earlier
in your own series that hasn't been applied (and you very well
know will not be until 1.5.4 is out, now we are deep in -rc
cycle)?

If so, you did a great disservice to me by sounding as if you
are blaming somebody else's existing bug.  I wasted some time
hunting for a non-existent bug in the code that is being readied
for 1.5.4 final for quite some time, in order to pick only the
relevant "fix" from your patch.

It turns out, luckily, existing code did not have such a bug.
What a relief for the maintainer in bugfix-only freeze mode.

Next time around, please mark the patch on the Subject: line to
be squashed to your earlier [PATCH 5/6] before [PATCH 6/6].
That will also solve the bisectability problem.

Anyway, thanks.  I was planning to queue the series in 'pu' or
'next' after tagging -rc3, so not be silent and giving a proper
fix was the right thing to do.  My above rant is just about the
presentation.