Thread (8 messages) flat view 8 messages, 3 authors, 2016-06-15

Re: [PATCH/resend] add--interactive: allow diff colors without interactive colors

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:44:02

Possibly related (same subject, not in this thread)

Matthias Kestenholz [off-list ref] writes:
I managed to throw something together which works and passes all
the tests. Documentation included. :-)
Is it because we do not usually test colours and the tests run
without terminals to make sure "color.* = auto" does not kick
in?
I would be happy for feedback and suggestions.
 * Shouldn't "color.git = true" with "color.diff = false" mean
   "I want colour for everything by default but I do not want to
   see coloured diff"?

 * git_foo_config() callback from git_config() returns 0 on
   success; the API change needs to be documented to warn
   others.

I haven't studied your patch very deeply so I may have misread
what you tried to do, regarding the first point, though.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help