Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: [BUG] git-diff-* --color oddness

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:44:02

Jeff King [off-list ref] writes:
I encountered some weirdness today with git-diff-{files,tree,index} and
--color.  They parse the --color command line option, but do _not_ call
git_config(git_diff_ui_config), so if the user has colors specified in
the config, they are not used.
This is very deliberate.  ui_config is about the Porcelains.
Ordinarily, I would say "nobody should use --color with diff-files". But
we do, in git-add--interactive (see Wincent's 4af756f3).
The plumbing deliberately not calling ui_config does not have
anything to do with them supporting explicit --color options.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help