Re: [PATCH] Remove duplication in t9119-git-svn-info.sh

Junio C Hamano [off-list ref] wrote:

"David D. Kilzer" [off-list ref] writes:

quoted

@@ -350,8 +355,8 @@ test_expect_success 'info unknown-symlink-directory' "
 	cd svnwc &&
 		ln -s unknown-directory unknown-symlink-directory &&
 	cd .. &&
-	ptouch gitwc/unknown-symlink-directory \
-	       svnwc/unknown-symlink-directory &&
+	ptouch svnwc/unknown-symlink-directory \
+	       gitwc/unknown-symlink-directory &&

Hmph.  Am I the only one who finds this repetition somewhat
disturbing?

"David D. Kilzer" [off-list ref] wrote:

Simplify arguments to ptouch bash function.

Not reading Junio's mind, I think he meant that you were swapping the
"gitwc/" and "svnwc/" args everywhere in your changeset.

Nevertheless, does your change make things work with older
versions of SVN?  I'm running 1.4.x everywhere these days, but
I seem to recall the version of SVN on kernel.org was giving
Junio trouble with the tests.

-- 
Eric Wong