Re: [PATCH] Optimize prefixcmp()

Hi,

On Sat, 29 Dec 2007, Marco Costalba wrote:

What your patch does not seem to avoid is a segfault if prefix or str 
are NULL pointers.

I am quite certain that it is not allowed to pass NULL pointers to strcmp, 
and even if it was, I maintain that it is bad style.

FWIW the test suite seems to agree with me, as it passes with my patch.

However, since you already seem to have a profiling setup ready, I would 
be interested in some numbers, i.e. if this patch is faster for you or 
slower, or shows no effect at all.

Ciao,
Dscho