Thread (4 messages) flat view 4 messages, 3 authors, 2016-06-15

Re: [PATCH] git-pull: don't complain about branch merge config if only fetching tags

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:44:01

Possibly related (same subject, not in this thread)

Gerrit Pape [off-list ref] writes:
quoted
I've seen this patch on this list in the past, but isn't "git
pull -t" a user-error?
If so, we shouldn't advertise the -t switch in the git-pull(1) manpage.
Perhaps.  Patches are welcomed as always.
As it stands, I'd understand 'git pull -t' as 'fetch _all_ tags and
branch heads and merge according to the configuration'.
Yeah, but that would mean that the current error message needs
to be kept, as that is the logical conclusion of "merge
according to the configuration".  Which is not so nice.

Perhaps using the same logic as your patch to detect the case of
"pull --tags and nothing else" case, and exit with non-zero
saying "you probably meant fetch --tags" would be a sane
compromise?  I dunno.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help