Re: [PATCH] git-send-email: Add --suppress-cc all
From: Joel Becker <hidden>
Date: 2016-06-15 22:44:01
On Mon, Dec 24, 2007 at 01:26:48PM -0800, David Brown wrote:
Add the 'all' option to --suppress-cc, allowing easier suppression of everything.
Thank you!
quoted hunk ↗ jump to hunk
Signed-off-by: David Brown <redacted> --- On Mon, Dec 24, 2007 at 01:03:25PM -0800, Joel Becker wrote:quoted
+ all - all of the above, thus only honoring '--to', '--cc', and '--bcc'I can squash this with the other patch if that would be cleaner. Dave Documentation/git-send-email.txt | 2 +- git-send-email.perl | 11 ++++++++++- 2 files changed, 11 insertions(+), 2 deletions(-)diff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt index 432f336..fdfb56e 100644 --- a/Documentation/git-send-email.txt +++ b/Documentation/git-send-email.txt@@ -125,7 +125,7 @@ The --cc option must be repeated for each user you want on the cc list. avoid including the patch author, 'cc' will avoid including anyone mentioned in Cc lines in the patch, 'sob' will avoid including anyone mentioned in Signed-off-by lines, and 'cccmd' will avoid - running the --cc-cmd. + running the --cc-cmd. 'all' will suppress all auto cc values. Default is the value of 'sendemail.suppresscc' configuration value; if that is unspecified, default to 'self' if --suppress-from is specified, as well as 'sob' if --no-signed-off-cc is specified.diff --git a/git-send-email.perl b/git-send-email.perl index cb9adf2..ef16824 100755 --- a/git-send-email.perl +++ b/git-send-email.perl@@ -275,7 +275,7 @@ my(%suppress_cc); if (@suppress_cc) { foreach my $entry (@suppress_cc) { die "Unknown --suppress-cc field: '$entry'\n" - unless $entry =~ /^(cccmd|cc|author|self|sob)$/; + unless $entry =~ /^(all|cccmd|cc|author|self|sob)$/; $suppress_cc{$entry} = 1; } } else {@@ -284,6 +284,15 @@ if (@suppress_cc) { $suppress_cc{'sob'} = 1 unless $signed_off_cc; } +if ($suppress_cc{'all'}) { + foreach my $entry (qw (ccmd cc author self sob)) { + $suppress_cc{$entry} = 1; + } + delete $suppress_cc{'all'}; +} + +printf "Suppressions: %s\n", join(',', keys(%suppress_cc)); + my ($repoauthor) = $repo->ident_person('author'); my ($repocommitter) = $repo->ident_person('committer');-- 1.5.3.7
-- "Can any of you seriously say the Bill of Rights could get through Congress today? It wouldn't even get out of committee." - F. Lee Bailey Joel Becker Principal Software Developer Oracle E-mail: joel.becker@oracle.com Phone: (650) 506-8127