Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: [PATCH] Move git send-email cover letter temporary file to $GIT_DIR

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:44:01

"David Symonds" [off-list ref] writes:
On Dec 22, 2007 5:49 PM, Junio C Hamano [off-list ref] wrote:
quoted
"David Symonds" [off-list ref] writes:
quoted
On Dec 22, 2007 12:09 PM, Junio C Hamano [off-list ref] wrote:
quoted
Don't you have $repo (an instance of Git) at that point?  You
should be able to ask repo_path() about it, shouldn't you?
Isn't git-send-email still useful outside a Git repo?
Then why does it run "rev-parse --git-dir"?
I'm suggesting that it should still function just fine without being
inside a repo, so it should adequately handle "rev-parse --git-dir"
returning 128.
Ah, true.  Then the current behaviour to use the $(pwd) for
temporary file area would be Ok for now.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help