Re: [PATCH] Make git send-email accept $EDITOR with arguments
From: Luciano Rocha <hidden>
Date: 2016-06-15 22:44:00
On Thu, Dec 20, 2007 at 09:14:06PM +0100, Gustaf Hendeby wrote: <snip>
quoted hunk ↗ jump to hunk
I'm not completely satisfied with the problem with embedded spaces, but my Perl skills aren't good enough to do anything about it. If anyone have any suggestions on how to do it, it would be greatly appreciated. None-the-less, even with this shortcoming, I think this is a step in the right direction. git-send-email.perl | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)diff --git a/git-send-email.perl b/git-send-email.perl index 248d035..47ae77c 100755 --- a/git-send-email.perl +++ b/git-send-email.perl@@ -400,7 +400,7 @@ EOT close(C); my $editor = $ENV{GIT_EDITOR} || $repo->config("core.editor") || $ENV{VISUAL} || $ENV{EDITOR} || "vi"; - system($editor, $compose_filename); + system((split ' ', $editor), $compose_filename);
That should be enough. Use system("$editor $compose_filename") to use
perl's implicit split or, in case of meta-characters in the string,
external sh -c.
Or always use the shell:
$shell = $ENV{SHELL} || "/bin/sh";
system($shell, "-c", "$editor $compose_filename");
BTW, maybe add a check for the return code?
system(...) == 0 or die "editor failed\n";
--
Luciano Rocha [off-list ref]
Eurotux Informática, S.A. <http://www.eurotux.com/> Attachments
- (unnamed) [application/pgp-signature] 189 bytes