Re: Serious bug with pretty format strings & empty bodies?
From: Jonathan del Strother <hidden>
Date: 2016-06-15 22:44:00
On Dec 19, 2007 6:28 PM, René Scharfe [off-list ref] wrote:
That's strange. Could you check if this happens with e52a5de, too? That's the commit that introduced --pretty=format. If it doesn't, could you then please try to bisect the bug?
As far as I can tell, e52a... never compiled - it's missing prefixcmp from git-compat-util.h, which doesn't get merged in till 8ab3e18. And yes, I still get junk output from that build. (Shame, I was looking forward to trying out the bisect tool...)
How many '<unknown>' markers are there in the output of version 1.5.3.7 (and e52a5de)? One per %b? Are they the only output or are they combined with parts of unrelated commits, too?
Only one per %b, and where they appear, they're the only output. However, even with those builds, I get junk output in addition to the <unknown> markers. That is, with a format string of "**%b**", there are three possible outputs : The correct one - eg **Added test for NSDictionary generator** The unknown one - eg **<unknown>** The complete junk one - eg **n del Strothereb0d794bacc1761e8a0681e9b144c514702d9b7a** The latter's 'body' is almost always terminated by an unprintable character, which always seems to be 03. Hmmm. I wonder if it's coincidence that I can only seem to spot this problem in my repos that have been set up via submodule init...