Thread (9 messages) flat view 9 messages, 2 authors, 2016-06-15

Re: [PATCH] Fix git-instaweb breakage on MacOS X due to the limited sed functionality

From: Wincent Colaiuta <hidden>
Date: 2016-06-15 22:44:00

El 19/12/2007, a las 11:57, Charles Bailey escribió:
-	sed "$script" "$1.tmp"  > "$1"
+	# The generated scripts assume that perl is /usr/bin/perl
+	# so the assumption here should be no more harmful
+	/usr/bin/perl -p -e "$script" "$1.tmp"  > "$1"
I think it's a bad idea to hard-code the perl path there; the  
generated scripts only assume /usr/bin/perl if the user hasn't  
overridden it at build time:

	PERL_PATH=/foo/perl make ...

Using just this should work fine anyway:

	perl -p -e ...

Cheers,
Wincent
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help