Re: [PATCH] Minor portability patch to git-submodule

Hi,

On Tue, 18 Dec 2007, Andy Dougherty wrote:

On Mon, 17 Dec 2007, Johannes Schindelin wrote:

quoted

On Mon, 17 Dec 2007, Andy Dougherty wrote:

quoted

-	git ls-files --stage -- "$@" | grep -e '^160000 ' |
+	git ls-files --stage -- "$@" | egrep -e '^160000 ' |

Nack.  egrep is not available on all platforms.  But then I have to 
wonder why not saying "grep '^160000 '" instead?

Your last suggestion is easily and obviously better -- I'll assume you 
don't need an explicit patch and can just hand-edit mine.  Still, I'd have 
thought egrep was fine.  As far as I recall, it goes back to v7 Unix.

This is just another instance where we should look at existing systems 
and not so much at standards documents.

Or are there non-unix systems at issue (perhaps cygwin variants or 
something) that have grep but not egrep?

Well, I checked msysGit, and it has it.

That is, kind of: it is just a wrapper, calling "grep -E".  Which means 
yet another fork() on a fork() challenged platform, so I would appreciate 
it if we could avoid it.

Thanks,
Dscho