Re: [PATCH] gitweb: Make config_to_multi return [] instead of [undef]
From: Jakub Narebski <hidden>
Date: 2016-06-15 22:44:00
On Sat, 15 Dec 2007, Jakub Narebski wrote:
This is important for the list of clone urls, where if there are no per-repository clone URL configured, the default base URLs are never used for URL construction without this patch. Add tests for different ways of setting project URLs, just in case. Note that those tests in current form wouldn't detect breakage fixed by this patch, as it only checks for errors and not for expected output.
The patch applied to master bc8b95ae4a4b21753e84bbfd28cbcbf1b3f6e0a8 does have above paragraph in commit message, but DOES NOT have the tests itself.
I have added tests _then_ I have realized that in current form they cannot detect regression corrected by this patch. So if you want, you can not apply changes to test (and remove paragraph about test from commit message).
See above...
quoted hunk ↗ jump to hunk
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index 24b3158..a746a85 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl@@ -1511,7 +1511,7 @@ sub config_to_int {sub config_to_multi { my $val = shift; - return ref($val) ? $val : [ $val ]; + return ref($val) ? $val : (defined($val) ? [ $val ] : []); }
And somehow (I don't know how[*1*]) patch got whitespace corrupted, and now the line is indented with spaces, instead of with tab. [*1*] Other patches are fine. -- Jakub Narebski Poland