Thread (12 messages) flat view 12 messages, 4 authors, 2016-06-15

Re: [PATCH] Don't use the pager when running "git diff --check"

From: Jeff King <hidden>
Date: 2016-06-15 22:43:59

On Thu, Dec 13, 2007 at 08:45:38PM +0100, Wincent Colaiuta wrote:
In 89d07f75 "git diff" learnt to not run the pager if the user passes
the --exit-code switch. This commit does the same for the --check
switch for the same reason: we want the user to get the exit status
from "git diff", not the pager.
But --check is also producing useful output, which might need paged. So
you are sacrificing existing interactive use of --check for scriptable
exit-code uses. If you really want the exit code, why not "git diff
--check --exit-code"?

OTOH, I am not too sad to lose the paging behavior; it would take quite
a few whitespace errors to scroll off the screen.

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help