Re: 'git fast-export' is crashing on the gcc repo

Junio C Hamano [off-list ref] writes:

Nicolas Pitre [off-list ref] writes:

quoted

On Wed, 12 Dec 2007, Alex Riesen wrote:

quoted

Nicolas Pitre, Tue, Dec 11, 2007 23:06:42 +0100:

quoted

Well, ignore the above.  It seems that most of stdio doesn't set errno 
so the above is crap.

Well, it had no reason to in this case. It's not an error.
It does not even have to do a syscall.

Which is why I later agreed with your patch.

Still, I like your swapping of size and nmemb parameters, regardless
of the "don't bother calling fwrite(3) if size is zero" fix.

I don't.  Far too obscure, looks like an unintentional wart waiting to
be corrected.

I think that the explicit test is the way to go here.

-- 
David Kastrup, Kriemhildstr. 15, 44793 Bochum