Re: [Resend PATCH 2/4] Use strbuf in http code

On Mon, Dec 10, 2007 at 10:04:52PM -0800, Junio C Hamano wrote:

Mike Hommey [off-list ref] writes:

quoted

 struct buffer
 {
-        size_t posn;
-        size_t size;
-        void *buffer;
+	struct strbuf buf;
+	size_t posn;
 };

With this definition of "struct buffer", I do not think this can be correct.

quoted

@@ -1267,10 +1257,8 @@ static struct remote_lock *lock_remote(const char *path, long timeout)
 {
 	struct active_request_slot *slot;
 	struct slot_results results;
-	struct buffer out_buffer;
-	struct buffer in_buffer;
-	char *out_data;
-	char *in_data;
+	struct buffer out_buffer = { 0, STRBUF_INIT };

How seriously have you proofread and tested this series before sending
it out?

Damn ! I did fix this on sunday and was pretty sure to have sent it :-/

Mike