Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH/RFC (amend)] autoconf: Add test for OLD_ICONV (squelching compiler warning)

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:43:56

Jakub Narebski [off-list ref] writes:
quoted
Which means the real-life compilation will get the warning on type
mismatch.  Wasn't OLD_ICONV about squelching that?
Gah, I don't know why I though OLD_ICONV was about compile errors, and
not about compile warnings. This version uses -Werror to check for
warnings; I hope it doesn't give false positives...
But use of -Werror means you are married to gcc, doesn't it?

How important is it to detect OLD_ICONV anyway, I have to wonder?
On Wed, 5 Dec 2007, Pascal Obry wrote:
...
quoted
Note also that you should remove all the hard-coded settings
in Makefile anyway.
No, I should not. ./configure script is purely optional in git,
Correct.  Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help