Re: [PATCH] Make Git accept absolute path names for files within the work tree

Hi,

On Tue, 4 Dec 2007, Robin Rosenberg wrote:

tisdag 04 december 2007 skrev Johannes Schindelin:

quoted

On Mon, 3 Dec 2007, Jeff King wrote:

quoted

On Mon, Dec 03, 2007 at 09:53:30PM +0100, Robin Rosenberg wrote:

quoted

code did not pass). Like Linus, this code does not resolve 
symlinks, but I forgot to state that it is by design. It solves my 
problem and

By design meaning "I didn't feel like implemening it because I do 
not personally care" or "I have some reason not to resolve 
symlinks"?

IMHO those symlinks would be a nice thing in some corner cases, but 
penalise the common case.  So I tend to believe the latter.  (See also 
Linus' message why he talks about his preference for the die() code 
path.)

Actually the forme.... I don't mind it being fixed if it doesn't cost 
too much.

I do remember the hassles I went through with get_relative_cwd() until I 
broke down and used chdir() two times (ugly).  So the latter reason is 
good enough that you do not even have to admit to the former reason ;-)

Ciao,
Dscho