Re: [PATCH] Simplify crud() in ident.c

Hi,

On Mon, 3 Dec 2007, Alex Riesen wrote:

Johannes Schindelin, Mon, Dec 03, 2007 21:47:09 +0100:

quoted

On Mon, 3 Dec 2007, Alex Riesen wrote:

quoted

+	return  c <= 32  ||
+		c == '.' ||
+		c == ',' ||
+		c == ':' ||
+		c == ';' ||
+		c == '<' ||
+		c == '>' ||
+		c == '"' ||
+		c == '\'';

Or enhance ctype.c.

That's be nice, but the "crud" conflicts with existing classification,
so I'd have to change the is*-macros as well. Don't feel like it.

I believe the code is never in hotpath anyway so the shorter the
better.

Really?

	return !!strchr(".,:;<>\"\\", c);

Ciao,
Dscho