Re: [PATCH/RFC] Use regex for :/ matching

On Mon, Dec 03, 2007 at 10:55:15AM +0000, Johannes Schindelin wrote:

quoted

The sha1 syntax :/ used to be a strict prefix match.
Instead, let's use a regular expression, which can save on

Heh: 
http://repo.or.cz/w/git/dscho.git?a=commitdiff;h=2546cd9732bb8d4bc1d2485ba7bbc1d5c8bac935

Hmm, the major difference seems to be that you grep the entire body,
whereas I grep just the oneline. My goal was to avoid matching the
search string in the message of a merge commit with merge summaries
turned on.

Except that I did not support ".." (does yours?), _and_ that my patch is 
not as nice as yours.

No, I didn't. I'm not sure it is sane, since :/ can contain free-form
text (and with a regex, .. is not that unlikely). And you can always do
git-log --not :/foo :/bar

But then, my patch also works when save_commit_buffer == 0.  But I can 
refactor this into its own patch, since it really is a separate issue.

Agreed.

-Peff