Thread (1 message) 1 message, 1 author, 2016-06-15

Re: Corrupted (?) commit 6e6db85e confusing gitk

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:43:55

Linus Torvalds [off-list ref] writes:
On Sun, 2 Dec 2007, Johannes Schindelin wrote:
quoted
Darn.  But when can "GIT_AUTHOR_DATE" be set to the empty string?  I mean, 
I understand unset'ing it.  But setting it to ""?
Well, regardless, I think we should make sure that git-commit-tree never 
writes out an invalid commit - no matter *how* insane input it gets. 
Making it complain loudly (with a 'die("Oh, no, you don't!")') would be a 
good idea.
FWIW, fmt_ident() records the current time (before the kh/commit series,
and after the fix I sent on top of kh/commit series), which may be a
reasonable alternative.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help