Thread (5 messages) flat view 5 messages, 3 authors, 2016-06-15

Re: [PATCH/RFC] "color.diff = true" is not "always" anymore.

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:43:55

Possibly related (same subject, not in this thread)

Jeff King [off-list ref] writes:
It would be nice to have a "git config --colorbool" option, but it has
the unfortunate problem that the stdout of "git config" is piped back to
the caller, so the isatty check is meaningless (and the "pager in use"
is similarly tricky). Perhaps it should go in Git.pm, so it at least
only needs to be written once.
About the isatty(3) check, you do not have to use the stdout to report
the result, though.  IOW, you could use the exit code from the command.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help