Thread (11 messages) flat view 11 messages, 3 authors, 2016-06-15

Re: [PATCH] Do check_repository_format() early

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:43:55

Johannes Schindelin [off-list ref] writes:
On Thu, 29 Nov 2007, Nguyen Thai Ngoc Duy wrote:
quoted
The comment is clearly not clear enough. Maybe this?

+                     if (!work_tree_env) {
+                             retval = set_work_tree(gitdirenv);
+                             /* config may override worktree (see
set_work_tree comment) */
+                             check_repository_format();
+                             return retval;
+                     }
Perfect.  Please make it so, and add my ACK.
Looks sensible, but can this be accompanied with a trivial test to
demonstrate the existing breakage?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help