Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: [PATCH] git-svn now reads settings even if called in subdirectory

From: Eric Wong <hidden>
Date: 2016-06-15 22:43:54

Gustaf Hendeby [off-list ref] wrote:
Previously, git-svn first read the .git/config file for settings as if
current working directory was the repository top-directory, and after
that made sure to cd into top-directory.  The result was a silent
failur to read configuration settings.  This patch changes the order
these two things are done.

Signed-off-by: Gustaf Hendeby <redacted>

---

This fix seems a bit too obvious, which makes me think I missed
something conceptual here.  However, the patch passes "make test" and
"make full-svn-test", and the problems I had with the svn.authorsfile
setting not being honored while fetching from a subdirectory are gone.
Thanks Gustaf,

Seems right to me (note: I never use the authors file feature myself).

Acked-by: Eric Wong <redacted>

-- 
Eric Wong
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help